[quote=“mcvflorin, post:57, topic:166000”]I propose some modifications to the standard:
-
ArmMode and DetailedArmMode should be merged. In other words ArmMode should be dropped and DetailedArmMode should be renamed to ArmMode.
Argument: It’s redundant to have two state variables for the same thing.[/quote]
Against. It was a deliberate choice to make ArmMode a separate “binary” state variable for ready scripting and UI implementation. The DetailedArmMode was added to handle the current, and future, expansion based upon what people “found” in their particular panels (both now, and over time).
BTW: I’d love to know if the other Panels have “more states” as I only added the few that we could readily find for the few Panels we were implementing at the time (plus those gleaned from some other Panel doco for the Elk) so we’re likely missing a few 8)
2. [i]RequestArmMode[/i] and [i]RequestQuickArmMode[/i] should be merged. Implementations should read the PIN code from the Text Field. If it's present, it should use it to Arm/Disarm ([i]RequestArmMode[/i]). If it's not, it should try to Arm/Disarm without the PIN code ([i]RequestQuickArmMode[/i]). If it fails, an error should be displayed to the user.
If someone can show me the Spec for how standard UPnP handles such cases, then we can change it if people really want it. I avoided “null” or “non-passed” arguments, since it wasn’t clear from what I could see from the UPnP specs how this was handled…
Of course, MiOS and Lua methods are fine with it, as they’re more like var-args in the way things are handled but it was not clear how UPnP wanted that handles, so I opted for the well-defined path.
If the UPnP spec is vague on this, then I’d opt to keep it as-is. If there’s a well-defined methodology for it, then just let us have a ptr and we can review the options.
3. PIN code should be made a [i]string[/i].
Argument: There are panels that have alphanumeric PIN codes. The standard should accommodate all types of panels.
Sure, no problem changing it if there are panels that require AlphaNumerics. I tended to make the DT's match those found in panels, so that UI's could provide the [limited] UI's necessary to drive them.
ie. a numeric Keypad UI, or limited popup keyboard with Numerics only.
If we have panels that are shown to have AlphaNumerics then more than happy to change it over.
Can you list the Panels that permit this?